Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for the number of entropy bits exposed in reportingdomain #9

Closed
ehsan opened this issue Jul 19, 2019 · 2 comments
Closed

Account for the number of entropy bits exposed in reportingdomain #9

ehsan opened this issue Jul 19, 2019 · 2 comments
Labels
inactive? Issue may be inactive

Comments

@ehsan
Copy link

ehsan commented Jul 19, 2019

Let's say on the impression side we have a link like:

<a href="..." reportingdomain="https://uniqueid.adtech.example/" ...>...</a>

https://github.com/csharrison/conversion-measurement-api#conversion-reports mentions the conversion report will be sent to:

https://reportingdomain/.well-known/register-conversion?impression-data=&conversion-data=&last-clicked=

The number of unique bits sent alongside with this request seems more than what's mentioned there, since uniqueid may be a string that is unique e.g. per user (like a hash of their email address) or per their device (like a fingerprint).

This could be solved for example by submitting the conversion report to:

https://reportingrootdomain/.well-known/register-conversion?impression-data=&conversion-data=&last-clicked=

Where reportingrootdomain is the eTLD+1 of reportingdomain.

@ehsan
Copy link
Author

ehsan commented Jul 19, 2019

It occurred to me that the work-around I suggested above may not be sufficient for removing all possible entropy here. Here is another possible example:

https://ad-tech.example is the impression side, where ad-tech.example has a first-party relationship with the user and e.g. knows User X is logged in right now. A unique domain is registered for each user account in the system and the reportingdomain attribute is set to that unique domain for ads appearing on https://ad-tech.example when the user is logged in. This would allow the reporting domain to learn about the identity of the user by looking at the Host header.

@csharrison
Copy link
Collaborator

The input reporting domain at impression time is defined as an eTLD+1, so you shouldn't be able to do tricks with unique sub-domains (see https://github.com/csharrison/conversion-measurement-api#impression-declaration). We should always send the report to the root.

If folks are registering unique full domains per user at impression time, they will hit a pretty difficult problem: matching users to those domains at conversion time in the advertiser's context. We only send reports to the reporting domain if they are declared in the conversion registration .well-known URL. In order to learn the unique reporting domain, the advertiser would need to cycle through every possible domain which is easily thwarted (see this section https://github.com/csharrison/conversion-measurement-api#limits-on-the-number-of-conversion-pixels).

@maudnals maudnals added the inactive? Issue may be inactive label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive? Issue may be inactive
Projects
None yet
Development

No branches or pull requests

4 participants