-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept-CH cache is not updated on redirects #41
Comments
I'm closing this as intentional, it seems like an abuse of the system to allow redirects to update the Accept-CH cache (instead of using a Critical-CH header). @yoavweiss in case I'm wrong |
Not sure I follow. Critical-CH depends on the Accept-CH cache in the first place, and there are normal reasons to send redirects. (And, IIRC, our implementation does process Accept-CH on redirect. The problem is the spec doesn't match.) |
I was about to follow up that I was wrong, will fix in #42 (since that fix seems to overlap with the need here). Sorry about that |
If, on a top-level navigation, we get a redirect, I believe the spec currently will not pick up Accept-CH on those rounds, since that happens at create and initialize a Document object. (See https://wicg.github.io/client-hints-infrastructure/#document-init and https://wicg.github.io/client-hints-infrastructure/#abstract-opdef-initialize-the-client-hints-set.)
Probably it should happen earlier, maybe in process a navigate fetch?
The text was updated successfully, but these errors were encountered: