New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attributionsrc set by window.open is broken with respect to URL parameters #407
Comments
Thanks for tracking this here. |
I am leaning toward option 2 myself, as it doesn't require option 1's modification of the HTML spec (with the backwards-compatibility concerns that might entail) and doesn't require adding a completely separate API surface as in option 3. |
I agree 2 seems like the simplest option. 3 was how the feature was originally implemented and there was a whole host of compat issues with adding more params to window.open. |
2 seems OK to me too, I can gather additional input regarding developer experience to confirm |
Otherwise, attributionsrc URLs containing special characters such as '=' are incorrectly truncated. WICG/attribution-reporting-api#407 WICG/attribution-reporting-api#408 Bug: 1322450 Change-Id: I6d861c2744f8be048633a6bc00305a4fc09ab73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3626039 Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Quick-Run: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#999949}
Otherwise, attributionsrc URLs containing special characters such as '=' are incorrectly truncated. WICG/attribution-reporting-api#407 WICG/attribution-reporting-api#408 Bug: 1322450 Change-Id: I6d861c2744f8be048633a6bc00305a4fc09ab73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3626039 Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Quick-Run: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#999949} NOKEYCHECK=True GitOrigin-RevId: 0a6664786e459a221e71cf6788f9e40aeb4499be
The inability to use
=
within a feature parameter forwindow.open
is a limitation of both the specification and Chromium's implementation. For example,attributionsrc=https://a.test?x=y&h=j
gets interpreted as:Some solutions we could consider:
window.open
spec and implementation to permit escaping/quoting of values.attributionsrc
feature values to be URL-encoded and perform URL-decoding on them before using them.attributionsrc
via a separate parameter towindow.open
.Originally reported in https://groups.google.com/a/chromium.org/g/attribution-reporting-api-dev/c/_Q_dYzbSo38.
The text was updated successfully, but these errors were encountered: