Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: sync-xhr #126

Closed
clelland opened this issue Jan 16, 2018 · 5 comments
Closed

Feature proposal: sync-xhr #126

clelland opened this issue Jan 16, 2018 · 5 comments
Assignees

Comments

@clelland
Copy link
Collaborator

Posting this here for completeness, there is a corresponding issue at whatwg/xhr#178 for the XHR spec change.

The proposal is to add a new feature, sync-xhr, which is enabled by default (default allowlist is *)

When disabled, calling send() on an XMLHttpRequest object with the async flag set to false will cause a NetworkError exception to be thrown. (This is chosen to avoid adding a new failure path for existing code which makes use of synchronous XHR)

@clelland clelland self-assigned this Jan 16, 2018
@RByers
Copy link

RByers commented Mar 2, 2018

Anything left before calling this done?

@clelland
Copy link
Collaborator Author

clelland commented Mar 2, 2018

Not for this issue, I suppose -- the PR is still out on whatwg/xhr#178, waiting on the changes to be made to HTML before it lands, I believe.

@annevk
Copy link
Member

annevk commented Mar 2, 2018

I think I was happy to land whatwg/xhr#177 provided implementation bugs were filed, but I see that in whatwg/xhr#177 you did note it depended on changes to HTML.

@RByers
Copy link

RByers commented Oct 2, 2018

This has landed in the spec and shipped in Chrome. Can we just add it to features.md and mark this as closed please? BTW is anything else missing from features.md?

@clelland
Copy link
Collaborator Author

clelland commented Oct 3, 2018

Added.

features.md could use a few changes -- It uses a normative voice when it really shouldn't, and should probably, in most cases, just link directly to the relevant specs, now that those are starting to integrate with FP themselves.

Eventually all of that documentation should be moved somewhere like MDN, but features.md may need to stick around for a while to document the things that aren't really standards yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants