Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WritableStream sizeAlgorithm should probably be nontrivial? #224

Open
domenic opened this issue Aug 26, 2020 · 0 comments
Open

WritableStream sizeAlgorithm should probably be nontrivial? #224

domenic opened this issue Aug 26, 2020 · 0 comments

Comments

@domenic
Copy link
Contributor

domenic commented Aug 26, 2020

Let sizeAlgorithm be an algorithm that returns 1.

This makes any backpressure (e.g. generated by fetchBody.pipeTo(nativeFSWritableStream) kind of useless. Wouldn't it be better to look at the chunks' length?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@domenic