Add setActionHandler() and rewrite parts of the specification related to controls handling (closes #147, closes #148) #159

mounirlamouri · 2016-12-23T14:07:34Z

mounirlamouri · 2016-12-23T14:14:15Z

@xxyzzzq this isn't finished but I thought it might be good for you to have an early look :)

mounirlamouri · 2016-12-23T14:19:15Z

A preview should be available here: https://mounirlamouri.github.io/sandbox/mediasession.html

xxyzzzq · 2016-12-23T14:25:41Z

index.bs

 };
 </pre>

 <p>
  A {{MediaSession}} objects represents a media session for a given document and
  allows a document to communicate to the user agent some information about the
-  playback and how to handle it.
+  playback and how to handlei it.


s/handlei/handle

xxyzzzq · 2016-12-23T14:26:40Z

index.bs

+the user agent MUST dispatch either a <a enum-value
+for=MediaSessionAction>play</a> or <a enum-value
+for=MediaSessionAction>pause</a> to the <a>media control event handler</a> of
+the <a>most meaningful media session</a> based on the <a>actual playback


You might need to rebase onto my latest change to active media session

Just did 😄

xxyzzzq · 2016-12-23T14:43:28Z

index.bs

+<p>
+  A <dfn>media session action</dfn> is an action that the page can handle in
+  order for the user to interact with the {{MediaSession}}. For example, a page
+  can handle some actions that will then be triggered when the user presses


s/then be triggered/be fired?

Fired is used for events so I'm afraid this could be confusing.

xxyzzzq · 2016-12-23T14:44:58Z

index.bs

+</p>
+
+<p>
+  A <a>media session action</a> is described by a {{MediaSessionAction}} which


a {{MediaSessionAction}} enum value?

I changed "described" by "represented". {{MediaSessionAction}} is an enum so I'm not sure if we need to repeat it in the text.

xxyzzzq · 2016-12-23T14:49:17Z

index.bs

+    </li>
+    <li>
+      <dfn enum-value for=MediaSessionAction>seekbackward</dfn>: the action
+      intent to move the playback time backward by a few second.


s/second/seconds
Or maybe we should say "by a short period"?

Used "by a short period (eg. few seconds)".

xxyzzzq · 2016-12-23T14:49:40Z

index.bs

+    </li>
+    <li>
+      <dfn enum-value for=MediaSessionAction>seekforward</dfn>: the action
+      intent is to move the playback time forward by a few second.


xxyzzzq · 2016-12-23T14:50:18Z

index.bs

+    </li>
+    <li>
+      <dfn enum-value for=MediaSessionAction>previoustrack</dfn>: the action
+      intent is to either starts the current playback from the beginning if the


s/starts/start

xxyzzzq · 2016-12-23T14:56:35Z

index.bs

+<p>
+  A <dfn title='media session action source'>media session action source</dfn>
+  is a source that might produce a <a>media session action</a>. Such source can
+  be the system or the user agent for UI surfaces created by it.


s/system/platform to be consistent?

s/the user agent for UI surfaces created by it/the UI surfaces created by the user agent?

I like the concept of "action source" :)

Done for both.

xxyzzzq · 2016-12-23T14:59:25Z

index.bs

+  agent MAY <a>queue a task</a> in order to notify all the known <a>media
+  session action sources</a> in order to avoid UI flickering when multiple
+  actions are modified in the same event loop.
+</p>


Add some word saying that the media session action sources should update themselves to be ready to receive the supported actions?

Maybe mention the "Processing media control actions" section? Maybe some merging is needed.

This is a note so it is not normative. I will check that the spec says that the sources should be updated. Otherwise, I will add this.

Hmm, I think I confused this with something else. Done.

xxyzzzq · 2016-12-23T15:01:57Z

index.bs

+<p>
+  It is RECOMMENDED for user agents to only handle the <a enum-value
+  for=MediaSessionAction>play</a> and <a enum-value
+  for=MediaSessionAction>pause</a> <a>media session actions</a> by default.


s/by default/using internal implementation by default?
s/"media session actions"/"media session actions" (ditto for other places)

I rephrased a bit the RECOMMENDED part.

Not sure what the s/"media session actions"/"media session actions" meant. It looks like the same string to me.

Not sure what the s/"media session actions"/"media session actions" meant. It looks like the same string to me.

Sorry, I mean to change it to <a lt="media session action">media session actions</a> because we don't have <dfn>media session actions</dfn> (the plural form).

Just realized that GitHub removes the tags unless I quote them in ``.

I think bikeshed handles the plural form automatically (at least, it seems) :)

mounirlamouri · 2017-01-03T15:48:05Z

PTAL. I've updated https://mounirlamouri.github.io/sandbox/mediasession.html but it might take a few minutes to propagate.

xxyzzzq

LGTM w/ nits. Thanks!

xxyzzzq · 2017-01-03T16:04:25Z

index.bs

+  <ul>
+    <li>
+      <dfn enum-value for=MediaSessionAction>play</dfn>: the action intent is to
+      resume the playback. The current <a>playback state</a> should not be


When this action is triggered from a media session action source, the current playback state should not be ...?

I mean both play and pause handlers can present at the same time, while the page can specify one play/pause playback state, right?

xxyzzzq · 2017-01-03T16:04:37Z

index.bs

+    <li>
+      <dfn enum-value for=MediaSessionAction>pause</dfn>: the action intent is
+      to pause a currently active playback. The current <a>playback state</a>
+      should be <a enum-value for=MediaSessionPlaybackState>playing</a>.


xxyzzzq · 2017-01-03T16:31:59Z

index.bs

-  </li>
-</ol>
+Whenever the <a>active media session</a> is changed, the user agent MUST run the
+<a>media session actions update algorithm</a>.


It's my mistake in the last PR. The UA must also run the metadata update algorithm as well.

… to controls handling (closes #147, closes #148)

mounirlamouri requested a review from xxyzzzq December 23, 2016 14:07

mounirlamouri force-pushed the set-action-handler branch from d8edb17 to 85efe16 Compare December 23, 2016 14:08

xxyzzzq reviewed Dec 23, 2016

View reviewed changes

mounirlamouri force-pushed the set-action-handler branch 2 times, most recently from 6ae46fe to 29c2360 Compare January 3, 2017 15:47

xxyzzzq approved these changes Jan 3, 2017

View reviewed changes

Add setActionHandler() and rewrite parts of the specification related…

04cb535

… to controls handling (closes #147, closes #148)

mounirlamouri force-pushed the set-action-handler branch from 29c2360 to 04cb535 Compare January 4, 2017 13:06

mounirlamouri merged commit 3d36a82 into master Jan 4, 2017

mounirlamouri deleted the set-action-handler branch January 4, 2017 13:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add setActionHandler() and rewrite parts of the specification related to controls handling (closes #147, closes #148) #159

Add setActionHandler() and rewrite parts of the specification related to controls handling (closes #147, closes #148) #159

mounirlamouri commented Dec 23, 2016

mounirlamouri commented Dec 23, 2016

mounirlamouri commented Dec 23, 2016

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

mounirlamouri Jan 3, 2017

xxyzzzq Dec 23, 2016

mounirlamouri Jan 3, 2017

xxyzzzq Jan 3, 2017 •

edited

mounirlamouri Jan 3, 2017

mounirlamouri commented Jan 3, 2017 •

edited

xxyzzzq left a comment

xxyzzzq Jan 3, 2017

mounirlamouri Jan 4, 2017

xxyzzzq Jan 3, 2017

mounirlamouri Jan 4, 2017

xxyzzzq Jan 3, 2017

mounirlamouri Jan 4, 2017

Add setActionHandler() and rewrite parts of the specification related to controls handling (closes #147, closes #148) #159

Add setActionHandler() and rewrite parts of the specification related to controls handling (closes #147, closes #148) #159

Conversation

mounirlamouri commented Dec 23, 2016

mounirlamouri commented Dec 23, 2016

mounirlamouri commented Dec 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xxyzzzq Jan 3, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mounirlamouri commented Jan 3, 2017 • edited

xxyzzzq left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xxyzzzq Jan 3, 2017 •

edited

mounirlamouri commented Jan 3, 2017 •

edited