Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What does excludeAcceptAllOption do? #134

Closed
foolip opened this issue Nov 20, 2019 · 0 comments · Fixed by #185
Closed

What does excludeAcceptAllOption do? #134

foolip opened this issue Nov 20, 2019 · 0 comments · Fixed by #185
Milestone
V1

Comments

@foolip
Copy link
Member

foolip commented Nov 20, 2019

For chooseFileSystemEntries() has an excludeAcceptAllOption options, non-normatively described as:

If options.excludeAcceptAllOption is true, or if no valid entries exist in options.accepts, a option matching all files will be included in the file types the dialog lets the user select.

Given the name and this description, I'm still not sure what it does. From the name it sounds like maybe it removes some checkbox or dropdown option from the native OS file picker? But from the description it sounds more like if there are no matches, then this will cause all files to become eligible for selection instead?
@mkruisselbrink mkruisselbrink added this to the V1 milestone Apr 9, 2020
mkruisselbrink added a commit that referenced this issue Jun 10, 2020
@mkruisselbrink
Change the API surface for getting native file system handles.
6df1c56 
Rather than having one method do three different things, just have
separate methods for all three options.

This fixes #170, fixes #134, fixes #133 and fixes #25.
mkruisselbrink added a commit that referenced this issue Jun 10, 2020
@mkruisselbrink
Change the API surface for getting native file system handles.
0677301 
Rather than having one method do three different things, just have
separate methods for all three options. Also aligns (mostly) with
the file handling API in how accepted file types are specified.

This fixes #170, fixes #134, fixes #133 and fixes #25.
@mkruisselbrink mkruisselbrink mentioned this issue Jun 10, 2020
Merged
mkruisselbrink added a commit that referenced this issue Jun 17, 2020
@mkruisselbrink
Change the API surface for getting native file system handles. (#185)
b1b9ce2 
* Change the API surface for getting native file system handles.

Rather than having one method do three different things, just have
separate methods for all three options. Also aligns (mostly) with
the file handling API in how accepted file types are specified.

This fixes #170, fixes #134, fixes #133 and fixes #25.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V1
Development

Successfully merging a pull request may close this issue.

Change the API surface for getting native file system handles. WICG/file-system-access
2 participants
@mkruisselbrink @foolip