Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding the IP address space to the network partition key #77

Open
letitz opened this issue Sep 22, 2022 · 0 comments
Open

Consider adding the IP address space to the network partition key #77

letitz opened this issue Sep 22, 2022 · 0 comments

Comments

@letitz
Copy link
Collaborator

letitz commented Sep 22, 2022

@annevk thoughtfully suggested this in #74. We could add the fetch client's IP address space to the network partition key used for fetches.

So far, it seems like the performance cost would be minimal. The vast majority of websites are public and would remain unaffected.

Such a change would present a small security benefit, as this approach would neatly prevent attacks using cache poisoning (see #74).

To me, the biggest benefit would be in simplifying the story around the HTTP cache (currently, we work around the lack of such partitioning by applying checks to the cache and invalidating entries in certain cases, which is complex), which would erase painful edge cases for users that frequently use the same website over public and private IPs. See for example https://crbug.com/1352591.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant