Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: [[DiscoverFromExternalSource]] uses same |options| name for two different variables #36

Open
mkruisselbrink opened this issue Mar 25, 2020 · 0 comments

Comments

@mkruisselbrink
Copy link

In step 2 in https://wicg.github.io/WebOTP/#sctn-discover-from-external-source you seem to re-assign |options| to be the OTPCredentialRequestOptions inside the CredentialRequestOptions object, however later in that algorithm you still use |options| to refer to the outer CredentialRequestOptions object. You should probably not use the same name for two different objects/variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant