Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent fallback loop when publisher publishes invalid SXG #432

Open
jyasskin opened this issue May 8, 2019 · 1 comment
Open

Prevent fallback loop when publisher publishes invalid SXG #432

jyasskin opened this issue May 8, 2019 · 1 comment

Comments

@jyasskin
Copy link
Member

jyasskin commented May 8, 2019

https://crbug.com/939684 handles this by removing application/signed-exchange from the Accept header on fallback, but @Gregable mentions the possibility of not-checking the signature for a same-origin signed exchange.

This interacts with #397 in that we'll want to make sure the loop prevention works for every reason we might use the fallback URL.

@jyasskin
Copy link
Member Author

jyasskin commented May 9, 2019

We also need to remember to check either Service-Worker-Allowed or a similar mechanism to make sure folks don't impersonate a path they're not authoritative for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant