Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Standardized Git-Package Pip-Install Syntax #293

Closed
ric-evans opened this issue Mar 12, 2021 · 0 comments
Closed

Use Standardized Git-Package Pip-Install Syntax #293

ric-evans opened this issue Mar 12, 2021 · 0 comments
Assignees
@dsschult
Labels
blocker bug dependencies Pull requests that update a dependency file

Comments

@ric-evans
Copy link
Member

The current syntax breaks downstream compatibility.

Replace:

iceprod/requirements.txt

Line 64 in 78799b5

-e git+https://github.com/WIPACrepo/rest-tools.git@197e5c17dd6d3aa7ba7dc0d9b9b2e0a620019c6e#egg=rest_tools

With:
git+https://github.com/WIPACrepo/rest-tools@v1.0.7#egg=rest_tools

Optionally, incorporate setup.py boilerplate from https://github.com/WIPACrepo/file_catalog/blob/master/setup.py -- in particular the git-pip regex check
@ric-evans ric-evans added bug blocker dependencies Pull requests that update a dependency file labels Mar 12, 2021
@dsschult dsschult self-assigned this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsschult dsschult

Labels
blocker bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsschult @ric-evans