Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validator for site infrastructure #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added validator for site infrastructure #11

wants to merge 1 commit into from

Conversation

snehasi
Copy link

@snehasi snehasi commented Apr 5, 2019

Hi,

I've added validator for site infrastructure, fixing #4.

We had to validate two fields - fqdn and ipv4 address - for the schema.

For fqdn, instead of going with a custom regex, I've used fqdn module from pypi as it implements fqdn validation fully compliant with RFC-1035 making it more robust.

For ip4 address, I've used yamale's built-in ip validator.

Looking forward to reviews on the PR.

@maany
Copy link
Member

maany commented Apr 6, 2019

Cool, I've tested the PR. It works well :) The task for GSoC is complete. I'll incorporate the PR into the code later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants