This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Introduce rest_do_request() for making REST requests internally
#1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routing requests through the server in a RESTful manner permits us to de-couple controllers from one another, permitting subclassing, etc. It also ensures all of the appropriate permission and validation checks are run on each internal request.
|
@WP-API/amigos How do you feel about this? |
| $get_request = new WP_REST_Request( 'GET', rest_url( 'wp/v2/' . $this->get_post_type_base( $this->post_type ) . '/' . $post->ID ) ); | ||
| $get_request->set_param( 'context', 'edit' ); | ||
| $response = $this->prepare_item_for_response( $post, $get_request ); | ||
| $response = rest_do_request( 'GET', '/wp/v2/' . $this->get_post_type_base( $this->post_type ) . '/' . $post->ID, array( 'context' => 'edit' ) ); |
There was a problem hiding this comment.
It would be nice if I could pass any arbitrary path, including one prepared with rest_url()
|
Per my Slack feedback, I'd like to see it return a $request = rest_do_requests( '/wp/v1/posts' );
if ( is_wp_error( $request ) ) {
return $request;
} |
danielbachhuber
pushed a commit
that referenced
this pull request
Jun 8, 2015
Introduce `rest_do_request()` for making REST requests internally
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routing requests through the server in a RESTful manner permits us to
de-couple controllers from one another, permitting subclassing, etc. It
also ensures all of the appropriate permission and validation checks are
run on each internal request.
See #1218