Don't add an empty comment

[DannyS712]

The script should not add a comment to an AfC submission when the comment field is blank.

Reason: no benefit in blank comments

Example: I clicked to quickly and made an empty comment at https://en.wikipedia.org/w/index.php?title=Draft:Funk_Night_Records&diff=885252905&oldid=885241822&diffmode=source, requiring another edit to actually add the comment

Solution: Check that the comment text isn't empty before proceeding

[DannyS712]

I think the relevant section is function handleComment starting at line 2226 of afch-rewrite/src/modules/submissions.js.

[Adityachaturvedi2906]

Hi, I would like to contribute to this issue, can you please guide me further?

[enterprisey]

@Adityachaturvedi2906 Sure! This issue isn't too complicated (good eye spotting it), so I've given it the appropriate label as well. Because this project is getting a steady stream of new contributors, if you don't mind I'll reserve just this one for you, so that the other ones can go to other people. (I'm also working on tagging more issues with good-first-issue, but I think it's fair to have only one open issue per person.)

You'll first want to check out the instructions at https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Articles_for_creation/Helper_script/Contributing to set everything up. Then, go to some draft page, then click on "Comment" (the yellow button on the right). Note that even though the text area is empty, the button is enabled. We would like to change that. One way to do this is by adding a listener to the input event that checks if the text area has any text in it, and enables the button if it does. When the button is disabled, it should have the disabled class set, and have the text "Enter a comment" or something like that. (To see an example of similar behavior, try going to "Accept" from the main menu (green button on the left) and entering Main page as the title. The button will be disabled and show a message.) And please let me know if you run into any issues here or in our Zulip channel. Thanks!

[Adityachaturvedi2906]

You'll first want to check out the instructions at https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Articles_for_creation/Helper_script/Contributing to set everything up. Then, go to some draft page, then click on "Comment" (the yellow button on the right).

Where can I find a Draft page?

[enterprisey]

https://test.wikipedia.org/wiki/Draft:Testing_AFCH

[enterprisey]

Issue is currently open for anyone

[MobolanleAdebesin]

Hi @enterprisey, I'm interested in this ticket! I am (or will be) a first-time contributor. Is it still available?

[enterprisey]

@MobolanleAdebesin Sure, thank you for your interest! My post above with instructions is still current. The developer guide is at https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Articles_for_creation/Helper_script/Contributing; let me know on this issue or via these routes if you have any questions.

[MobolanleAdebesin]

@enterprisey awesome, thanks!

[vartikaSaxena]

@enterprisey is this issue resolved? If not, I would like to work on it.

[aknouche]

@enterprisey I am very happy that I have found this project. I am interested in fixing this bug. I am a first time contributor to this project. Can you assign it to me? Thanks!

[souravnmaji]

I want to contribute to this issue , can anyone guide me further

[enterprisey]

@vartikaSaxena @aknouche @souravnmaji see #105 (comment), you may all work on it together or separately

[vartikaSaxena]

Sure. Thanks! @enterprisey.
Since, I am a beginner I would be happy if @aknouche or @souravnmaji also want to work on it.

[souravnmaji]

Yes , I am also interested in working with @vartikaSaxena and @aknouche
Lets work together and explore open source contribution😁

[SHIVANGISINGH1]

I want to contribute to this issue ,but I can not find the draft page and the comments section can you tell me where I can find it.

[Amey1619]

@enterprisey ,Hi I want to contribute to this issue , can you assign this issue to me .