New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JSHint and JSCS with ESLint. #88

Merged
merged 4 commits into from Apr 5, 2018

Conversation

Projects
None yet
2 participants
@bardiharborow
Contributor

bardiharborow commented Jan 13, 2018

  • Replaces the current linting solution with the one MediaWiki core uses (which is more modern) and enables the MediaWiki standard configuration. In order to make the tests pass easily, I've had to disable quite a few rules, but I'll go through and review the errors later.
  • Due to a few linting exemption issues, it was easier to remove the dependancies directory and use the Hogan.js npm package instead.
@enterprisey

This comment has been minimized.

Member

enterprisey commented Apr 5, 2018

LGTM. Thank you for working on this!

@enterprisey enterprisey merged commit 837efdb into WPAFC:master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bardiharborow bardiharborow deleted the bardiharborow:eslint branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment