New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JSHint and JSCS with ESLint. #88

Merged

enterprisey merged 4 commits into wikimedia-gadgets:master from bardiharborow:eslint

Apr 5, 2018

Contributor

bardiharborow commented Jan 13, 2018 •

edited

Loading

Replaces the current linting solution with the one MediaWiki core uses (which is more modern) and enables the MediaWiki standard configuration. In order to make the tests pass easily, I've had to disable quite a few rules, but I'll go through and review the errors later.
Due to a few linting exemption issues, it was easier to remove the dependancies directory and use the Hogan.js npm package instead.

bardiharborow added 4 commits

April 5, 2018 12:32


          Rename misc/ to contrib/.

86864b0


          Remove JSHint and JSCS and install ESLint.

685d874


          Replace dependencies/ with NPM packages.


          Apply lint rules to codebase.

aa922f6

Contributor

enterprisey commented Apr 5, 2018

LGTM. Thank you for working on this!

enterprisey merged commit 837efdb into wikimedia-gadgets:master

bardiharborow deleted the eslint branch

April 5, 2018 07:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment