Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for the new gallery block #812

Merged
merged 2 commits into from Jul 4, 2023
Merged

Conversation

dgwyer
Copy link
Contributor

@dgwyer dgwyer commented Jun 29, 2023

This PR includes the new gallery block which uses a modern structure and tooling, based on the @wordpress.create-block script.

As this PR introduces new npm packages and removes others it's recommended to do an npm ci. If that doesn't work then delete the node_modules folder and package.json and run npm i. I'm using Node version 16.18.0.

Build files are included in the commit so there is no need to compile the block source before testing. But if you want to build then either run npm start to build/watch or just npm run build to build.

To test just add a gallery block to a page and check it displays ok on the frontend and in the editor.

@dgwyer dgwyer requested a review from giucu91 June 30, 2023 09:02
@dgwyer
Copy link
Contributor Author

dgwyer commented Jun 30, 2023

@giucu91 I noticed the tests failed after submitting the PR. Can you let me know the status of the tests on this repo. i.e. Is it something in the PR causing them to fail or a more general issue?

Update with latest changes from 2.7.5 branch
@razvanaldea89
Copy link
Contributor

razvanaldea89 commented Jun 30, 2023

When going through the present galleries something weird happens to the select: it multiplies or something.

image

Also, on the first attempt of saving a page with the new block a JSON error appeared. After a few tries it went away and never happened.

Update: Seems to be happening ( the duplication ) if a gallery doesn't have images.

@dgwyer
Copy link
Contributor Author

dgwyer commented Jun 30, 2023

Thanks for testing. 😊

I just tried the 2.7.5 branch and the duplication issue is happening there, so it's not specific to this PR I don't think.

image

And would you mind elaborating on the JSON issue? What was the issue exaclty that you saw, and are the steps replicable?

Also, on the first attempt of saving a page with the new block a JSON error appeared. After a few tries it went away and never happened.

@giucu91 giucu91 merged commit 0c0a821 into 2.7.5 Jul 4, 2023
1 check failed
razvanaldea89 added a commit that referenced this pull request Jul 12, 2023
This reverts commit 0c0a821, reversing
changes made to b7855a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants