Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmedia 428 allow list themesettings domains #1137

Merged
merged 2 commits into from Oct 15, 2021

Conversation

JackHowa
Copy link
Contributor

Description

Add domains for Theme Settings images to safelist

Jira Ticket

Acceptance Criteria

    1. Images uploaded via Theme Settings UI are added to the Arc safelist

Test Steps

  • Tests should pass as arc domain logic is tested there

Effect Of Changes

Before

  • Theme settings urls specified may not be allowed client-side resizing

After

  • All theme settings urls are allowed client-side resizing

Dependencies or Side Effects

  • Matthew talked with theme settings team to get the list

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@JackHowa JackHowa requested a review from a team as a code owner October 15, 2021 14:32
@JackHowa JackHowa merged commit 0604b3c into canary Oct 15, 2021
@JackHowa JackHowa deleted the TMEDIA-428-allow-list-themesettings-domains branch October 15, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants