Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag release in Docker #1069

Closed
soulgalore opened this issue Dec 15, 2017 · 7 comments
Closed

Tag release in Docker #1069

soulgalore opened this issue Dec 15, 2017 · 7 comments

Comments

@soulgalore
Copy link
Contributor

Hi Pat,
it would be super if the Docker containers could be automatically tagged with the release (you can just set it up in the Docker hub).

Right now it's mostly using the latest tag and I think it is rebuilt on every push to Github?
For example: our documentation for getting WPT up and running locally on Docker is broken since something changed between releases and in the instructions we download the latest tag (since there is no other).

Best
Peter

@soulgalore
Copy link
Contributor Author

And same for https://github.com/WPO-Foundation/wptagent that would be awesome!

@pmeenan
Copy link
Contributor

pmeenan commented Jan 8, 2018

I changed the "latest" tag to pull the release branch which will be more stable. Is there a way to do a one-time build of each release tag if you want to have tagged docker builds specific to each release?

@soulgalore
Copy link
Contributor Author

not one time build (you can always push a new one) but if you have autobuild turned on, you can let it build a docker tag per git tag:

screen shot 2018-01-08 at 9 30 03 pm

@timothyclarke
Copy link
Contributor

If the trigger button does not appear (per some of mine) you need to create a Token in "Build Triggers" and then add it as a webhook in this repo (on a "Create" event).

Dockerhub side
docker trigger url

@mattfarina
Copy link

To add a little context, for repeatibility of deploys we want versioned releases. latest could changes between dev, testing, and deploys to production introducing unforeseen situations. Versioned releases give us a little more control.

@pmeenan
Copy link
Contributor

pmeenan commented Jan 9, 2018

ok, I set up builds with the wildcard tag settings so all new tagged releases should automatically get a build (if it works as expected).

I also manually triggered a build for both the server and agent for the WebPageTest-17.08 release tag.

The "latest" tag will track master and a "release" tag will track the release branch which will usually be a little behind master but ahead of the last stamped release.

@pmeenan
Copy link
Contributor

pmeenan commented Mar 7, 2018

There are now:

  • latest - tracks the trunk
  • release - tracks the release branch (expect updates roughly monthly)
  • release-specific tagged versions - For each WEbPageTest release (quarterly) there will be a tagged docker container automatically created

@pmeenan pmeenan closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants