Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Implement sniff] Disallow advertising/tracking codes #125

Open
3 tasks
grappler opened this issue Feb 12, 2017 · 5 comments
Open
3 tasks

[Implement sniff] Disallow advertising/tracking codes #125

grappler opened this issue Feb 12, 2017 · 5 comments

Comments

@grappler
Copy link
Member

Rule type:

Error

Rule:

Advertising/tracking codes in both PHP as well as JS and CSS and any other potential files which contain this type of code. Google search code cx=[0-9]{21}:[a-z0-9]{10} and Google advertising code pub-[0-9]{16}

Theme check file covering this rule:

https://github.com/WordPress/theme-check/blob/master/checks/badthings.php

To do:

  • Add the rule in the Theme Review handbook to the Requirements page.
  • Create unit tests
  • Create new sniff
@kkoppenhaver
Copy link

@grappler If no one is tackling this already, I can take a look at this one.

@grappler
Copy link
Member Author

grappler commented May 4, 2017

@kkoppenhaver That would be great! No one is working on this yet.

@kkoppenhaver
Copy link

@carolinan Thanks for the heads up on that! I'll take a look.

@dingo-d dingo-d added this to the 0.2.x/0.3.0 Next milestone May 18, 2019
@dingo-d
Copy link
Member

dingo-d commented May 18, 2019

@kkoppenhaver Hi! Any news on this sniff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants