Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions have typo for installing module #21

Closed
maderlock opened this issue Nov 24, 2023 · 2 comments
Closed

Instructions have typo for installing module #21

maderlock opened this issue Nov 24, 2023 · 2 comments

Comments

@maderlock
Copy link

The composer instruction is correct, but the Magento name of the module is not the same. This is the line that is failing for me:

magento module:enable scientiamobile/module-magento2-image-cdn-imageengine

That gives the error Unknown module(s): 'scientiamobile/module-magento2-image-cdn-imageengine'

It looks like the composer packagist string got used instead of the module vendor/name. Looking in registration.php, I can see that the Magento module name is ScientiaMobile_IO. Also, as the previous command was designed to be run from the top-level, it's common to run magento from there too, making the correct line:

./bin/magento module:enable ScientiaMobile_IO

Though this line is commonly skipped as just running ./bin/magento setup:upgrade will enable the module and also install it. Without any data or schema instructions, this is not required, but in case you later have this it's good to include in the instructions.

@jonarnes
Copy link
Contributor

Thank you very much for your feedback!
We'll look into this ASAP and release a fix

@jonarnes
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants