Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review try / finally blocks to ensure clarity #1217

Open
hazendaz opened this issue Apr 3, 2021 · 0 comments
Open

Review try / finally blocks to ensure clarity #1217

hazendaz opened this issue Apr 3, 2021 · 0 comments
Assignees

Comments

@hazendaz
Copy link
Member

hazendaz commented Apr 3, 2021

See #1214 , try/finally block is being used to perform action that is not directly part of the try block need. This is a bit confusing and causal coding in that area can cause code to be broken easily by moving out of the try block code that doesn't need to be in a try block to start with. The indirect close in this case is a side effect of the finally block but not really that clear. All code should be reviewed to see how often this is done and see if this can be written in a better way so that any code movement doesn't indirectly break code relying on finally in that way.

@hazendaz hazendaz self-assigned this Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant