Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet / deposit] dialogue for depositing funds on Hive-Engine.com (instructions are generated for each token separately) #3368

Closed
Diana-Cherry-8 opened this issue Nov 29, 2021 · 22 comments
Assignees
Labels
Medium task priority medium new new task
Milestone

Comments

@Diana-Cherry-8
Copy link
Collaborator

Diana-Cherry-8 commented Nov 29, 2021

Back-task #3464

yammer 1606
wallet / deposit

dialogue for depositing funds on Hive-Engine.com (instructions are generated for each token separately)

Deposit
All crypto deposits are processed by Hive-Engine.com. Once the deposit is made, you will receive an equal amount of the SWAP version of the deposited token, which can be exchanged for other tokens on the Hive-Engine blockchain.
There is a 1% fee on deposits. ETH, ERC-20, BNB, BEP-20, Polygon (MATIC) and Polygon ERC-20 deposits have no deposit fees.
Please note that you will also have to pay standard network fees when sending cryptos.
Step 1: Select the crypto token to deposit:
Step 2: Follow the deposit instructions:
Please select the crypto token first. / Attention: Failure to specify the memo will result in loss of funds!
2021-11-29_09-28

@Diana-Cherry-8
Copy link
Collaborator Author

Кнопка Done активна, при открытии модального окна (когда ничего не выбрано)
2022-01-17_19-16

@Diana-Cherry-8
Copy link
Collaborator Author

Diana-Cherry-8 commented Jan 17, 2022

Добавить две точки после:
Step 1
Step 2
Memo (required field)
Account
2022-01-17_19-24

@Diana-Cherry-8
Copy link
Collaborator Author

Diana-Cherry-8 commented Jan 17, 2022

Полные название валют не всегда отображаются - уточнить у бека
2022-01-17_19-32

@Diana-Cherry-8
Copy link
Collaborator Author

Добавить сортировку для списка валют по алфавиту
2022-01-17_19-42

@Diana-Cherry-8
Copy link
Collaborator Author

Diana-Cherry-8 commented Jan 17, 2022

@Fesmofet По сравнению с tribaldex не хватает валют:
BUILDTEAMBTS
EM
EOSSAND
HIVE
SAND - странно выглядит на tribaldex
TELOSKANDA
EOSWEED

@Diana-Cherry-8
Copy link
Collaborator Author

Diana-Cherry-8 commented Jan 18, 2022

При открытии модалки 1х несколько секунд отображается предыдущее ее состояние (при Slow 3G хорошо видно)

vokoscreen-2022-01-18_11-24-16.mp4

@Diana-Cherry-8
Copy link
Collaborator Author

Добавить лоадер при переключении валют

@Diana-Cherry-8 Diana-Cherry-8 moved this from Dev to Staging testing in Waivio 2021-2024 Jan 18, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Diana-Cherry-8 commented Jan 18, 2022

При виборе hive, запросы convert и deposit-withdraw возвращают ошибки "There is no such coin pair HIVE -> SWAP.HIVE" "pair" is required
2022-01-18_16-01

@Diana-Cherry-8
Copy link
Collaborator Author

Diana-Cherry-8 commented Jan 18, 2022

@Fesmofet После нажатия на Done летит запрос для записи информации о депозите в блокчейн, чтобы мы потом могли это отображать и в истории (эта дополнительная запись только для deposit)

@Diana-Cherry-8
Copy link
Collaborator Author

Кнопка Done активна, при открытии модального окна (когда ничего не выбрано) 2022-01-17_19-16

После того как мы добавим запись в блокчейн, это нужно будет добавить

@Fesmofet
Copy link
Collaborator

Fesmofet commented Jan 19, 2022

after each convert request send custom_json operation with following parameters:
{id: 'waivio_hive_engine', json : { action: 'createDepositRecord' payload : { from_coin: { type: String, required: true }, to_coin: { type: String, required: true }, destination: { type: String, required: true }, pair: { type: String, required: true }, address: { type: String }, account: { type: String }, memo: { type: String }, ex_rate: { type: Number, required: true }, }}}

@Diana-Cherry-8 Diana-Cherry-8 moved this from Staging testing to With comments in Waivio 2021-2024 Jan 19, 2022
@lucykolosova lucykolosova moved this from With comments to Dev in Waivio 2021-2024 Jan 21, 2022
@lucykolosova lucykolosova moved this from Dev to In progress in Waivio 2021-2024 Jan 21, 2022
@lucykolosova lucykolosova moved this from In progress to Dev in Waivio 2021-2024 Jan 21, 2022
@lucykolosova lucykolosova moved this from Dev to Staging testing in Waivio 2021-2024 Jan 21, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Для hive нужно добавить переход сразу в трансер

@Diana-Cherry-8 Diana-Cherry-8 moved this from Staging testing to With comments in Waivio 2021-2024 Jan 24, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Diana-Cherry-8 commented Jan 24, 2022

Swap.Hive не приходит (memo отличается от того которые сейчас на проде)

vokoscreen-2022-01-24_10-54-01.mp4

@Diana-Cherry-8 Diana-Cherry-8 moved this from With comments to Staging testing in Waivio 2021-2024 Jan 24, 2022
@Diana-Cherry-8 Diana-Cherry-8 moved this from Staging testing to With comments in Waivio 2021-2024 Jan 24, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Транзакция меньше 0.001 не будет приходить, так как минимальный fee (налог на проведение транзакции) = 0.001

@Diana-Cherry-8
Copy link
Collaborator Author

Staging checked

@Diana-Cherry-8 Diana-Cherry-8 moved this from With comments to Production testing in Waivio 2021-2024 Jan 24, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Production checked

@Diana-Cherry-8 Diana-Cherry-8 moved this from Production testing to Testing waivio in Waivio 2021-2024 Jan 26, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Fix broadcast deposit

after each convert request send custom_json operation with following parameters: {id: 'waivio_hive_engine', json : { action: 'createDepositRecord' payload : { from_coin: { type: String, required: true }, to_coin: { type: String, required: true }, destination: { type: String, required: true }, pair: { type: String, required: true }, address: { type: String }, account: { type: String }, memo: { type: String }, ex_rate: { type: Number, required: true }, }}}

@Diana-Cherry-8 Diana-Cherry-8 moved this from Testing waivio to With comments in Waivio 2021-2024 Jan 27, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Diana-Cherry-8 commented Jan 31, 2022

Если и у пользователя закончилось rc (broadcast 500) и он выбирает валюты в депозит модалке, то инструкции для hive не отображаются, или продолжает отображаться предыдущая. (если это другие валюты то инструкции отображаются)
2022-01-31_11-07
2022-01-31_10-44

@Diana-Cherry-8
Copy link
Collaborator Author

Поле меньше текста, если выбрать Hive и нажать Continue
2022-01-31_14-04

@Diana-Cherry-8
Copy link
Collaborator Author

Уточнить - from_coin и to_coin передают ссылки - это так и нужно
2022-01-31_14-18

@lucykolosova lucykolosova moved this from With comments to Dev in Waivio 2021-2024 Jan 31, 2022
@Diana-Cherry-8 Diana-Cherry-8 moved this from Dev to Staging testing in Waivio 2021-2024 Feb 1, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Staging checked

@Diana-Cherry-8 Diana-Cherry-8 moved this from Staging testing to Production testing in Waivio 2021-2024 Feb 1, 2022
@Diana-Cherry-8
Copy link
Collaborator Author

Production checked

@Diana-Cherry-8 Diana-Cherry-8 moved this from Production testing to Testing waivio in Waivio 2021-2024 Feb 2, 2022
@Diana-Cherry-8 Diana-Cherry-8 moved this from Testing waivio to Done in Waivio 2021-2024 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium task priority medium new new task
Projects
Development

No branches or pull requests

4 participants