Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace should work on Collections, not simply arrays #15

Open
11 tasks
WaldoJeffers opened this issue May 12, 2018 · 0 comments
Open
11 tasks

Replace should work on Collections, not simply arrays #15

WaldoJeffers opened this issue May 12, 2018 · 0 comments
Assignees
@WaldoJeffers
Labels
enhancement New feature or request

Comments

@WaldoJeffers
Copy link
Owner

WaldoJeffers commented May 12, 2018 •
edited

Checklist

  • Decide if replace should accept the value or the key it's trying to replace
  • It should work on objects
  • It should work on sets
  • It should work on maps
  • It should work on strings
    • If the index is a number, it should replace the matching character
    • If the index is a character, it should replace all matching occurrences of this character
    • If the index is RegExp, it should replace all the matches from the RegExp
  • It should accept a function in place of the index parameter
  • Add tests
  • Update documentation
@WaldoJeffers WaldoJeffers self-assigned this May 12, 2018
@WaldoJeffers WaldoJeffers added the enhancement New feature or request label May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WaldoJeffers WaldoJeffers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WaldoJeffers