Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the use of socket server in connectors example #2754

Merged
merged 4 commits into from Dec 27, 2018
Merged

Fix the use of socket server in connectors example #2754

merged 4 commits into from Dec 27, 2018

Conversation

cararemixed
Copy link
Contributor

Python 3 renamed this and import will fail on case sensitive filesystems.

Brian Mitchell added 3 commits December 27, 2018 16:11
Fix the use of socket server in connectors example
f0ba5d4 
Python 3 renamed this and import will fail on case sensitive filesystems.
Include sys
65cb82b
Fix UDP source connector
50c228a
@cararemixed cararemixed self-assigned this Dec 27, 2018
@cararemixed cararemixed added this to the 0.6.1 milestone Dec 27, 2018
@cararemixed
Copy link
Contributor Author

Fixes #2752.

JONBRWN
JONBRWN approved these changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@JONBRWN JONBRWN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed working for both python 2 and 3

@JONBRWN JONBRWN merged commit f32a88d into release-0.6.1 Dec 27, 2018
@JONBRWN JONBRWN deleted the socketserver-compat branch December 27, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JONBRWN JONBRWN JONBRWN approved these changes

Assignees

@cararemixed cararemixed

Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cararemixed @JONBRWN