Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnectSwiftV2 swift package not correctly published #329

Closed
Tracked by #1031
zkhalapyan opened this issue Jul 12, 2022 · 10 comments
Closed
Tracked by #1031

WalletConnectSwiftV2 swift package not correctly published #329

zkhalapyan opened this issue Jul 12, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@zkhalapyan
Copy link

zkhalapyan commented Jul 12, 2022

Describe the bug

Trying to get the hello world project out to test out WalletConnectSwiftV2; can't import the WalletConnectSign object in order to use Sign as in the example here.

SDK Version

  • Client: Swift
  • Version: 5

To Reproduce

  1. Add WalletConnectSwiftV2 as a dependency to a Swift/Xcode/iOS project following instructions here.
  2. Type import WalletConnectSign
  3. Notice that you get an error No such module as "WalletConnectSign"

Expected behavior
Following the example app to import WalletConnectSign.

Screenshots

Screen Shot 2022-07-12 at 10 23 09 AM

our problem.

Additional context
On main branch!

@llbartekll
Copy link
Contributor

hey @zkhalapyan
can you specify what is a "Version: 5"...
we do not have that tag anywhere
the last one is v0.8.1-beta.102 and I recommend to use it.

@zkhalapyan
Copy link
Author

I have been pulling the package off the main branch; via File -> Add Package

For some odd reason, it's pulling in from https://github.com/WalletConnect-Labs/WalletConnectSwiftV2!

@zkhalapyan
Copy link
Author

Like adding the package https://github.com/WalletConnect/WalletConnectSwiftV2 from Xcode, is bringing in the archived GitHub repo! 🤷‍♂️

Screen Shot 2022-07-12 at 12 21 03 PM

@zkhalapyan
Copy link
Author

Ah, I see what's happening: if you add https://github.com/WalletConnect/WalletConnectSwiftV2 to Xcode's package search, it will bring up the older library called WalletConnectSwiftV2 🤦‍♂️

Screen Shot 2022-07-12 at 12 22 26 PM

@llbartekll
Copy link
Contributor

Screenshot 2022-07-12 at 18 54 30
you are using WalletConncet-labs/ repo, it is not this one

@zkhalapyan
Copy link
Author

How do you actually add the real one? I am following the installation instructions here.

If you literally copy/paste https://github.com/WalletConnect/WalletConnectSwiftV2, you still old WalletConnectSwiftV2 and it's extremely easy mistake to pick the old one since it's hard to see the - in the name 🤦‍♂️

@zkhalapyan
Copy link
Author

@llbartekll my best guess is that the library not correctly published; both of the results below are not the correct ones lol one is old the other one is named correctly, but archived, this is quite confusing. I would take the following actions:

  1. Publish the correct WalletConnectSwiftV2 (this repo)
  2. Kill the archived/old package called WalletConnectSwiftV2 so that there is no confusion
  3. Keep WalletConnectSwift which is pointing to V1 since there are probably some real users out there

I would verify that it works by searching for this repo's URL and making sure the correct WalletConnectSwiftV2 pops up.

Screen Shot 2022-07-12 at 3 33 59 PM

@zkhalapyan zkhalapyan changed the title No such module as "WalletConnectSign" WalletConnectSwiftV2 swift package not correctly published, leading to devs installing the archived repo also named WalletConnectSwiftV2 Jul 12, 2022
@zkhalapyan zkhalapyan changed the title WalletConnectSwiftV2 swift package not correctly published, leading to devs installing the archived repo also named WalletConnectSwiftV2 WalletConnectSwiftV2 swift package not correctly published Jul 12, 2022
@llbartekll
Copy link
Contributor

@zkhalapyan I think you may have some cache in xcode.

  1. double tap on the WalletConnectSwiftV2 package
  2. tap delete
  3. paste https://github.com/WalletConnect/WalletConnectSwiftV2 in search textfield
  4. this package will display so you can add it

@zkhalapyan
Copy link
Author

That's correct, was caching the older version; deleting the cache, fetching with the new URL worked. Thank you!

@AndriiPetrovDev
Copy link

AndriiPetrovDev commented Aug 11, 2023

I have the same issue, but all links look fine. I chose all possible checkboxes to avoid mistakes when something important isn't imported. I've cleaned the SPM cache, derived data, and project build folder, but still have a problem.

SCR-20230811-ops
SCR-20230811-oqi
SCR-20230811-ov3
SCR-20230811-ouq

@asi90sp asi90sp mentioned this issue Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants