Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retry failed RPC lookups 2 times #265

Closed
chris13524 opened this issue Jul 13, 2023 · 1 comment · Fixed by #624
Closed

feat: retry failed RPC lookups 2 times #265

chris13524 opened this issue Jul 13, 2023 · 1 comment · Fixed by #624
Assignees
@chris13524
Labels
accepted The issue has been accepted into the project

Comments

@chris13524
Copy link
Member

While we use weights to prioritize certain providers over others, we don't eliminate errors whenever we hit a low-weighted RPC provider.

We should retry the lookup to the weighting system 2 times to avoid getting errors as much as possible.

It should retry on a non-2xx status code. Possibly it could also detect that the body contains a JsonRpcResponse error or a non-JsonRpcResponse value.

We should also report metrics on this.
@arein arein added the accepted The issue has been accepted into the project label Jul 13, 2023
@Rakowskiii Rakowskiii self-assigned this Jul 14, 2023
@chris13524 chris13524 assigned chris13524 and unassigned Rakowskiii Jul 31, 2023
@chris13524
Copy link
Member Author

Also add timeouts trying to get a request from the upstream provider. If it times out, retry again.

@geekbrother geekbrother mentioned this issue Jan 11, 2024
Open
@chris13524 chris13524 mentioned this issue Apr 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
3 participants
@arein @chris13524 @Rakowskiii