Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't wipe response_message #216

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: don't wipe response_message #216

merged 1 commit into from
Sep 28, 2023

Conversation

chris13524
Copy link
Member

Description

This was being set to None in all cases for some reason. This may be hiding some issues.

Resolves #215

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Sep 27, 2023
@arein arein added the accepted The issue has been accepted into the project label Sep 27, 2023
@chris13524 chris13524 merged commit 37a5a31 into main Sep 28, 2023
8 checks passed
@chris13524 chris13524 deleted the fix/dont-wipe-response-message branch September 28, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xav xav xav approved these changes

@geekbrother geekbrother geekbrother approved these changes

@arein arein Awaiting requested review from arein

Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: don't wipe response_message
4 participants
@chris13524 @xav @geekbrother @arein