-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: using relay public key from environment variable #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
212a9fd
to
94796e9
Compare
Show Plan
Action: |
94796e9
to
d8c337a
Compare
Show Plan
Action: |
d8c337a
to
411fef5
Compare
Show Plan
Action: |
Show Plan
Action: |
727a462
to
d86e543
Compare
Show Plan
Action: |
d86e543
to
7ae2d01
Compare
Show Plan
Action: |
7ae2d01
to
a11ffd6
Compare
Show Plan
Action: |
a11ffd6
to
c1ca639
Compare
Show Plan
Action: |
c1ca639
to
726f90a
Compare
Show Plan
Action: |
726f90a
to
97574d8
Compare
Show Plan
Action: |
97574d8
to
3925136
Compare
Show Plan
Action: |
chris13524
reviewed
Oct 10, 2023
Show Plan
Action: |
deserialization
2186e67
to
b4f8e42
Compare
Show Plan
Action: |
chris13524
approved these changes
Oct 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the public key to be used from the environment variable instead of grabbing it from the relay URL.
The following changes (commits) are made:
public_key_url
to the environment variables and passing it from the GitHub secrets and to the terraform. Making it usable from the Config. (commit),Resolves #228
How Has This Been Tested?
Tested by functional unit tests in CI workflow
Due Diligence