Use dapp identity key with aud, per spec #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devceline
force-pushed
the
refactor/notify-client-symkey-delete
branch
from
74e5dfd
to
1addad2
Compare
devceline
changed the title
bkrem
requested changes
Aug 22, 2023
| @@ -237,7 +237,7 @@ export class NotifyClient extends INotifyClient { | |||
| if (existingSubExists) return; | |||
|
|
|||
| this.messages.set(subTopic, { topic: subTopic, messages: [] }); | |||
| this.core.crypto.setSymKey(subscription.symKey).then(() => { | |||
| this.core.crypto.setSymKey(subscription.symKey, subTopic).then(() => { | |||
There was a problem hiding this comment.
Yes - doesn't hurt to have it
| ksu: this.client.keyserverUrl, | ||
| scp, | ||
| act: "notify_subscription", | ||
| app: metadata.url, | ||
| }; | ||
|
|
||
| console.log( |
There was a problem hiding this comment.
Keeping logs for now as they're needed for testing
| @@ -429,8 +437,19 @@ export class NotifyEngine extends INotifyEngine { | |||
| async (event: RelayerTypes.MessageEvent) => { | |||
| const { topic, message, publishedAt } = event; | |||
|
|
|||
| console.log( | |||
| const payload = await this.client.core.crypto.decode(topic, message); | ||
|
|
||
| console.log("Decoded: ", payload); |
Co-authored-by: Ben Kremer <ben@walletconnect.com>
bkrem
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec: https://specs.walletconnect.com/2.0/specs/clients/notify/notify-authentication#notify-subscription
We were using dapp url as
audin all JWTs, when it should be dapp identity key.The reason this worked so far is because the
audfield was not validated yet