Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve notifications in case when client re-registered with same id #236

Open
geekbrother opened this issue Oct 5, 2023 · 0 comments
Open

fix: preserve notifications in case when client re-registered with same id #236

geekbrother opened this issue Oct 5, 2023 · 0 comments
Assignees
@geekbrother
Labels
accepted The issue has been accepted into the project

Comments

@geekbrother
Copy link
Contributor

At the moment when the create_client is called all the related to the supplied client.id notifications are deleted from the notifications table.
We can preserve the notification records in this case as this is expected behavior for some clients to re-register instead of creating a "clean" client.
@geekbrother geekbrother self-assigned this Oct 5, 2023
@arein arein added the accepted The issue has been accepted into the project label Oct 5, 2023
@geekbrother geekbrother mentioned this issue Oct 5, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekbrother geekbrother

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arein @geekbrother