Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handling expired APNS certificates properly #308

Closed
geekbrother opened this issue Mar 13, 2024 · 1 comment · Fixed by #314
Closed

fix: Handling expired APNS certificates properly #308

geekbrother opened this issue Mar 13, 2024 · 1 comment · Fixed by #314
Assignees
@geekbrother
Labels
accepted The issue has been accepted into the project

Comments

@geekbrother
Copy link
Contributor

At the moment Apns(ConnectionError(hyper::Error(Io, Custom { kind: InvalidData, error: "received fatal alert: CertificateExpired" }))) causing a 500 HTTP error.
We should handle properly expired certificates instead of throwing 500 errors.
@geekbrother geekbrother self-assigned this Mar 13, 2024
@arein arein added the accepted The issue has been accepted into the project label Mar 13, 2024
@chris13524
Copy link
Member

chris13524 commented Mar 18, 2024 •
edited
Loading

When this error happens suspend the tenant: https://walletconnect.slack.com/archives/C058RS0MH38/p1710782583542969?thread_ts=1710726001.743679&cid=C058RS0MH38

This will result in a 202 response code not a 5xx.

@chris13524 chris13524 mentioned this issue Mar 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekbrother geekbrother

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: APNs certificate expired error WalletConnect/push-server
3 participants
@arein @chris13524 @geekbrother