Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_sendRawTransaction not work , eth_sendTransaction return signtransaction #44

Closed
BankLife opened this issue Sep 9, 2019 · 10 comments

Comments

@BankLife
Copy link

BankLife commented Sep 9, 2019

eth_sendRawTransaction not work and eth_sendTransaction return signtransaction.
Did I do it wrong or trustwallet didn't support it yet?

@pedrouid
Copy link
Member

pedrouid commented Sep 9, 2019

This has been reported before but I believe that it was fixed now.
Could you try to update your Trust Wallet app?
If the problem persists could you share the operating system and app version.

@BankLife
Copy link
Author

BankLife commented Sep 9, 2019

i use apk file download (https://trustwallet.com/dl/apk) . run with bluestacks

@pedrouid
Copy link
Member

pedrouid commented Sep 9, 2019

Pinging the Trust Wallet team to help you with this issue
cc @hewigovens @vikmeup @leoneparise

@hewigovens
Copy link

Hi, we don't support eth_sendRawTransaction, because you don't have to rely on client to send the raw tx, you should only call signing realted methods.

for eth_sendTransaction, we will brodcast it and return the tx id? what's the current behavior? Our Android developers will take a look

@BankLife
Copy link
Author

BankLife commented Sep 10, 2019

"{ "id": 63816738723811796, "jsonrpc": "2.0", "method": "eth_sendTransaction", "params": [{"from": "0x44871486ec3c2c9ea2d517af6bfddb4ad30d22df", "to": "0xCb76728c3676c1166978eb1dc3575286AA5b330e", "data": "", "gasLimit": "100000", "gasPrice": "0x9184e72a000", "value": "1000000000000000000" , "nonce": "0x117" }] }"

https://i.imgur.com/XewhTpn.png
return

{"id":63816738723811796,"jsonrpc":"2.0","result":"0xf86d808503b9aca000830186a094cb76728c3676c1166978eb1dc3575286aa5b330e880de0b6b3a76400008025a06e2ed906fd2733eca13e9db945f1613506e23c03e11b03193bba4900d0a62062a070b09d3776c9ccdfbd233d63ec1d9be28b9f82fac82b6c7932a029ac9c1fa7bd"}"

i think result not txid because eth_signTransacion also returns the result as above

@hewigovens
Copy link

Can you share your android app version? This looks like old build behavior, we return raw tx in the first implementation not tx id

@BankLife
Copy link
Author

BankLife commented Sep 10, 2019

i use apk file download (https://trustwallet.com/dl/apk) . run with bluestacks . I also deleted the apk file and downloaded it to the Google play store of Bluestacks, but the result is still the same
Android 7.1.1

https://i.imgur.com/bokgu0w.png

TrustWallet version 1.7.030

i updated to 1.7.42 , but still the same

@BankLife
Copy link
Author

@hewigovens help me

@hewigovens
Copy link

we will fix this issue in future release, meanwhile you can try iOS

@leoneparise
Copy link

@BankLife It's fixed now in Android. Please wait until the next build is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants