Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code Modal doesn't show which wallets a users can use #323

Closed
p0s opened this issue Jul 27, 2020 · 3 comments
Closed

QR Code Modal doesn't show which wallets a users can use #323

p0s opened this issue Jul 27, 2020 · 3 comments

Comments

@p0s
Copy link

p0s commented Jul 27, 2020

Issue

Our imToken wallet user gave us the feedback that not all WalletConnect-supporting DApps show which wallets are actually working with WalletConnect during the 'Connect with WalletConnect' QR code modal.

Possible solution

The goal: Let people know about the many wallets that support WalletConnect inside the DApp, right next to the QR code

The lower picture shows one solution. Maybe there's a more beautiful one that can also be integrated into the Web3Modal

image

User stories

As a user who opens the WalletConnect QR code on [any WalletConnect-supported DApp]. I would like to see which wallet app I can actually use with to scan that QR can, in order to use this DApp with the wallet app I like most.

As a complete noob without any wallet, I want to know which wallet I can use with WalletConnect after the WalletConnect QR code pops up, so that I can install this wallet app and get going.

@Kundn-lal
Copy link

Unable to open QR modal Wallet Connect
my code :

const provider = new WalletConnectProvider({
infuraId: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
});

    await provider.enable();

    // @ts-ignore
    this.web3 = new Web3(provider);

previously same code working but i checked again it is not working...

getting this log :

ZoneAwarePromise {__zone_symbol__state: null, __zone_symbol__value: Array(0)}

any help !

@finessevanes
Copy link
Contributor

@Kundn-lal if you're still having an issue, please create it's separate issue.

@finessevanes
Copy link
Contributor

Closing this because this feature is done in v2.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants