Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile deeplinking keeps selected wallet #394

Closed
pacoccino opened this issue Dec 14, 2020 · 4 comments
Closed

Mobile deeplinking keeps selected wallet #394

pacoccino opened this issue Dec 14, 2020 · 4 comments

Comments

@pacoccino
Copy link
Contributor

pacoccino commented Dec 14, 2020

When using the mobile deeplinking, WalletConnect seems to store the mobile wallet selected, but doesn't allow for changing it.

It means that once a mobile wallet is selected from the qrcode-modal, we cannot ever use another wallet again.
I would suggest to first disable this feature, as a user may want to connect to different wallets on differents apps.
In a second step, think about a better UX for allowing users to reset/change that stored parameter.

@pacoccino
Copy link
Contributor Author

Up here @pedrouid, after seeing #444

It is impossible to switch to another wallet once we selected one in the wallet connect mobile modal.

The only workaround I found for now in my app is to clear all users local storage, which is not super convenient.

Could you please either disable this feature, or allow to clear the choice.

@shmuel-web
Copy link

@pedrouid
same here
I cant switch the account

at the very least give us a warning in the docs ;)

@Knaackee
Copy link

Knaackee commented Jul 19, 2021

@pakokrew good information!

Since it is almost silent here and the problem seems to still exist, i digged a little deeper and there are actually two settings that get stored in local storage.
So the workaround for me is to delete these two from local storage before connect.
With this, off course, the other information stored in local storage still exists.

window.localStorage.removeItem('walletconnect');

window.localStorage.removeItem(
  'WALLETCONNECT_DEEPLINK_CHOICE'
);

@finessevanes
Copy link
Contributor

Is this still an issue? @pakokrew @shmuel-web

@finessevanes finessevanes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants