Does not compile on esm.sh

[hazae41]

When compiling "walletconnect" or "@walletconnect/web3-provider" on https://esm.sh, we get the following error

https://cdn.esm.sh/v14/walletconnect@1.3.3/esnext/walletconnect.development.js

/* esm.sh - error */
throw new Error("[esm.sh] " + "yarn: warning walletconnect \u003e @walletconnect/utils \u003e rpc-payload-id@1.0.0: Packaged deprecated in favor of @json-rpc-tools/utils\nwarning walletconnect \u003e @walletconnect/web3-provider \u003e web3-provider-engine \u003e request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142\nwarning walletconnect \u003e @walletconnect/web3-provider \u003e web3-provider-engine \u003e eth-block-tracker \u003e safe-event-emitter@1.0.1: Renamed to @metamask/safe-event-emitter\nwarning walletconnect \u003e @walletconnect/web3-provider \u003e web3-provider-engine \u003e eth-json-rpc-filters \u003e safe-event-emitter@1.0.1: Renamed to @metamask/safe-event-emitter\nwarning walletconnect \u003e @walletconnect/web3-provider \u003e web3-provider-engine \u003e eth-json-rpc-middleware \u003e safe-event-emitter@1.0.1: Renamed to @metamask/safe-event-emitter\nwarning walletconnect \u003e @walletconnect/web3-provider \u003e web3-provider-engine \u003e eth-json-rpc-filters \u003e json-rpc-engine \u003e safe-event-emitter@1.0.1: Renamed to @metamask/safe-event-emitter\nwarning walletconnect \u003e @walletconnect/web3-provider \u003e web3-provider-engine \u003e request \u003e har-validator@5.1.5: this library is no longer supported\nerror Couldn't find the binary git\n");
export default null;

The failing error is "Couldn't find the binary git"

[esm.sh] yarn: warning walletconnect > @walletconnect/utils > rpc-payload-id@1.0.0: Packaged deprecated in favor of @json-rpc-tools/utils
warning walletconnect > @walletconnect/web3-provider > web3-provider-engine > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning walletconnect > @walletconnect/web3-provider > web3-provider-engine > eth-block-tracker > safe-event-emitter@1.0.1: Renamed to @metamask/safe-event-emitter
warning walletconnect > @walletconnect/web3-provider > web3-provider-engine > eth-json-rpc-filters > safe-event-emitter@1.0.1: Renamed to @metamask/safe-event-emitter
warning walletconnect > @walletconnect/web3-provider > web3-provider-engine > eth-json-rpc-middleware > safe-event-emitter@1.0.1: Renamed to @metamask/safe-event-emitter
warning walletconnect > @walletconnect/web3-provider > web3-provider-engine > eth-json-rpc-filters > json-rpc-engine > safe-event-emitter@1.0.1: Renamed to @metamask/safe-event-emitter
warning walletconnect > @walletconnect/web3-provider > web3-provider-engine > request > har-validator@5.1.5: this library is no longer supported
error Couldn't find the binary git

It seems WalletConnect relies on git in order to compile.
Maybe we could ditch git, or provide a ESM build directly?

[pedrouid]

well the first warning regarding a deprecation is because of a library migration from rpc-payload-id to @json-rpc-tools/utils. To fix this I've published a pre-release for v1.3.4-rc.1 that fixes this issue (release on Monday for v1.3.4)

now about the web3-provider-engine that's not a dependency I actually maintain so I'm not entirely sure how to handle that particular issue

if you have any tips on how we could distribute ESM builds for walletconnect-monorepo... please feel free to make suggestions and if it there isn't many issues I could include it by Monday on the next release

[hazae41]

@pedrouid You can use esbuild https://github.com/evanw/esbuild

[hazae41]

The issue seems fixed, it works now, even with the same module version