Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React Native] @walletconnect/react-native-dapp can not find wallets on android 11. targetSdkVersion = 30 #618

Closed
inuyashaaa opened this issue Oct 3, 2021 · 10 comments

Comments

@inuyashaaa
Copy link

@walletconnect/react-native-dapp can not find wallets on android 11. targetSdkVersion = 30

@amaioru0
Copy link

amaioru0 commented Oct 5, 2021

I have the same issue

@goulart81
Copy link

I have the same issue, my phone has Android 10

@inuyashaaa
Copy link
Author

@pedrouid Could you help to check it?. Google play store required targetSdkVersion=30, so we can not submit the app to the store if it is not fixed.

@amaioru0
Copy link

Hi sorry for the off topic @inuyashaaa I am wondering since you mentioned google play store, do you have any information regarding the policy around Ethereum mobile dapps? Like would they approve apps where you can sign in by signing a message, paying for gas to conduct operations within the app and how about revenue what if I would have a contract and users could benefit in the app from paying something through their mobile wallet?

@inuyashaaa
Copy link
Author

@amaioru0 My app is the mobile version of this website: https://bunicorn.exchange. Which have swap, farm, NFT... feature and google play store is approved. I thinks dapps is easy to agree with by the google team.

@amaioru0
Copy link

@inuyashaaa , Hi there thanks so much for your reply. It's a relief to hear this~!

@Shazad0304
Copy link

Shazad0304 commented Oct 28, 2021

if (!canOpenURL) {
Linking.openURL('https://walletconnect.org/wallets');
throw new Error('No wallets found.');
}

removing this from @WalletConnect\react-native-dapp\dist\providers\WalletConnectProvider.js worked for me.

@AleeeKoi
Copy link

Using Android SDK >= 30 require to specify a configuration in the manifest, so the code reported by @Shazad0304 won't fail any more.

<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.example">
    [...]

    <queries>
      <intent>
          <action android:name="android.intent.action.VIEW" />
          <data android:scheme="http"/>
      </intent>
      <intent>
          <action android:name="android.intent.action.VIEW" />
          <data android:scheme="https"/>
      </intent>
    </queries>
</manifest>

@therealharpaljadeja
Copy link

therealharpaljadeja commented Apr 29, 2022

image

canOpenURL() returns false for Android 11.

@finessevanes
Copy link
Contributor

Is this still an issue?

@finessevanes finessevanes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants