Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "@react-native-async-storage/async-storage" dependency #164

Open
nlnw opened this issue Mar 18, 2024 · 2 comments
Open

Remove "@react-native-async-storage/async-storage" dependency #164

nlnw opened this issue Mar 18, 2024 · 2 comments
Assignees

Comments

@nlnw
Copy link

nlnw commented Mar 18, 2024

This dependency adds 200MB to npm installs because it also pulls in react-native. It's more than 10x bigger than any other dependency. This makes anything that uses walletconnect as a package need 500mb+ in wasted storage. Can you please find a way to include this type of dependency without pulling in this package which pulls in react-native unecessarily?

@ganchoradkov
Copy link
Member

Hey @nlnw, this dep is defined as peer and only downloaded in dev mode https://github.com/WalletConnect/walletconnect-utils/blob/master/misc/keyvaluestorage/package.json#L51 It shouldn't be present in prod builds.
How are you measuring the bundle size?

@nlnw
Copy link
Author

nlnw commented Mar 23, 2024

It's not present in the final bundle, but it's still a waste to make all developers download this giant dependency, especially since it's not even used (the next largest dependency is 10x smaller). I mostly pick this up through viem. You can see how big that dependency is through this tool: https://pkg-size.dev/viem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants