Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: New architecture support #137

Closed
patrikduksin opened this issue Feb 14, 2024 · 5 comments
Closed

[bug]: New architecture support #137

patrikduksin opened this issue Feb 14, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@patrikduksin
Copy link

patrikduksin commented Feb 14, 2024

Description

On the first video I turned on new arch and have some strange behavior:

  1. Slide animation begins from the bottom left edge, should be just from the bottom
  2. Wallet logos doesn't show.

FYU: I tried to change rn image to expo-image and logos show as expected.

RocketSim_Recording_iPhone_15_Pro_6.1_2024-02-14_13.44.06.mp4
RocketSim_Recording_iPhone_15_Pro_6.1_2024-02-14_13.53.41.mp4

Web3Modal SDK version

@web3modal/wagmi-react-native 1.2.0

Output of npx react-native info

System:
  OS: macOS 14.3.1
  CPU: (8) arm64 Apple M1 Pro
  Memory: 184.61 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.10.0
    path: ~/.asdf/installs/nodejs/20.10.0/bin/node
  Yarn:
    version: 1.22.21
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.2.5
    path: ~/.asdf/plugins/nodejs/shims/npm
  Watchman:
    version: 2024.01.22.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: Not Found
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 21.0.2
    path: /usr/bin/javac
  Ruby:
    version: 3.0.3
    path: /Users/patrikduksin/.asdf/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.4
    wanted: 0.73.4
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: true
  newArchEnabled: true

Expo Version (if applies)

Expo 50.0.6

Steps to reproduce

npm i
npx expo run:ios

Snack, code example, screenshot, or link to a repository

https://github.com/patrikduksin/rn-wallet-connect-bug.git

@patrikduksin patrikduksin added the bug Something isn't working label Feb 14, 2024
@glitch-txs
Copy link
Member

Do you get any errors on the console?

@patrikduksin
Copy link
Author

hey @glitch-txs nothing
image

@ignaciosantise
Copy link
Collaborator

Hey @patrikduksin 👋 thanks for reporting!

You should be able to connect to wallets without issues, but sadly it seems that RN new architecture has some issues regarding images -> facebook/react-native#33131

And about the modal animation, its also a dependency issue: react-native-modal/react-native-modal#757

In this case, we'll wait to see if they solve the issue, and if they don't, we'll evaluate migrating to another modal lib

@ignaciosantise ignaciosantise closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
@patrikduksin
Copy link
Author

@ignaciosantise @glitch-txs Hello, as I see you are not planing to support new arch. It's important for us to use it, so can I use web3modal lib with my own UI modal? Maybe you have a documentation about it

@ignaciosantise
Copy link
Collaborator

@patrikduksin we added a temporary workaround for the image loading issue in v1.2.1 version until react-native solves the Image component problem

As i said, except from this UI issues, the SDK supports the new architecture and you should be able to connect with wallets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants