Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Weak network / offline handling #1289

Open
arein opened this issue Aug 21, 2023 · 0 comments · Fixed by #1662
Open

[bug] Weak network / offline handling #1289

arein opened this issue Aug 21, 2023 · 0 comments · Fixed by #1662
Labels
bug Something isn't working good first issue needs review

Comments

@arein
Copy link
Member

arein commented Aug 21, 2023

Link to minimal reproducible example

See below

Summary

Repro steps:
a - connect wallet to https://lab.web3modal.com/with-wagmi/react
b - disable network
c - click "Sign Message"

Actual behavior: button not greyed out and no error message
Expected behavior: button greyed out and failure message if there is no ACK within X seconds or if the ACK is false with an error message

Screenshot 2023-08-21 at 12 46 34 PM

List of related npm package versions

v2 latest
@arein arein added bug Something isn't working needs review labels Aug 21, 2023
@xzilja xzilja changed the title [bug] failing message errors swallowed [bug] Week network / offline handling Oct 10, 2023
@xzilja xzilja changed the title [bug] Week network / offline handling [bug] Weak network / offline handling Oct 10, 2023
@tomiir tomiir mentioned this issue Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue needs review
Projects
Web3Modal Web
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: back button unresponsive after network switch WalletConnect/web3modal
2 participants
@arein @boidushya