Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite actions are not supported #115

Closed
igdianov opened this issue Sep 18, 2023 · 2 comments
Closed

Composite actions are not supported #115

igdianov opened this issue Sep 18, 2023 · 2 comments

Comments

@igdianov
Copy link

The Retry action is quitting silently with success exit code 0 when a composite action is used with it. It looks like only node actions are supported at the moment, but it is not obvious to users due to this check: https://github.com/Wandalen/wretry.action/blob/js_action/src/Retry.js#L52-L54.

@dmvict
Copy link
Collaborator

dmvict commented Sep 19, 2023

Hello @igdianov

The action supports only nodejs actions. Here is description of features.

I did no added the tests for unsupported action types. The check of the type you can find in line 60. You've given the condition for pre and post steps.

We are adding basic support of Docker actions in #60. But we do not plan to write a runner for composite actions because composite action is a workflow inside action. The action can retry single command or nodejs action but not workflow.

@dmvict
Copy link
Collaborator

dmvict commented Sep 21, 2023

Hello @igdianov

Here I covered the case with unsupported action types. The action should throw error for composite action.

If you need to retry composite action, extract its steps and retry them, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants