Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board layout #682

Closed
WandererXII opened this issue Jun 11, 2023 · 19 comments
Closed

Board layout #682

WandererXII opened this issue Jun 11, 2023 · 19 comments
Labels
bug Something isn't working debatable Not sure if worth working on, or if it's something that is desirable enhancement New feature or an improvement of an existing one ideas wanted An idea how to solve issue needed

Comments

@WandererXII
Copy link
Owner

Layout overflows the screen on vertical screens:
image
Users can solve it by making the board smaller, but that's obv not optimal.

We want to rewrite once and for all uniboard.scss. We probably need to drop the old side layout, cause trying to maintain one is enough...

Related issues from lichess:
lichess-org#9522
lichess-org#12837

@WandererXII WandererXII added the bug Something isn't working label Jun 11, 2023
@WandererXII
Copy link
Owner Author

If we got rid of the side layout, we could have shogiground take care of hands and have it inside .sg-wrap possibly making it easier to properly scale and position, instead of this mess:
image

@WandererXII
Copy link
Owner Author

Currently the side layout is used by 4464 users, which makes me a bit hesitant to remove it... I could set everyone to the compact layout in the next update and see how many people switch back and then decide.

@WandererXII

This comment was marked as resolved.

@WandererXII WandererXII added enhancement New feature or an improvement of an existing one debatable Not sure if worth working on, or if it's something that is desirable ideas wanted An idea how to solve issue needed labels Jun 11, 2023
@WandererXII

This comment was marked as resolved.

@Olekaze
Copy link

Olekaze commented Jun 23, 2023

I prefer the side layout for chu shogi. the clock is too small on the other ones

@WandererXII
Copy link
Owner Author

The clocks are the same size, it's just that chu shogi has that (kinda ugly) gap there where hand pieces would go with other variants...
image
image

@WandererXII

This comment was marked as resolved.

@Rechefiltr-is-Fire

This comment was marked as resolved.

@WandererXII

This comment was marked as resolved.

@Rechefiltr-is-Fire

This comment was marked as resolved.

@WandererXII

This comment was marked as resolved.

@CouchTomato87

This comment was marked as resolved.

@WandererXII

This comment was marked as resolved.

@CouchTomato87

This comment was marked as resolved.

@Olekaze

This comment was marked as resolved.

@WandererXII
Copy link
Owner Author

I might revert to the shorter move list like lichess has. Lichess has two moves per line, we have only one, because of how moves are counted, so that's why I made the move list longer, but maybe I should revert that. On my laptop the difference is small, but on bigger monitors the clocks are too much spread out and away from the board like you say.
I would like to preserve the same column layout across all variants, that's why I'm reluctant to get rid of the gaps, but I will try it, maybe it won't bother me that much.

@milkymia93
Copy link

dont know how github works, but i use the side view for streaming layout and it works wonders with obs because it has the board background in it as well. i much prefer the side layout to any other layout, and especially for streaming shogi.

@WandererXII
Copy link
Owner Author

Unfortunately side layout was already removed here and soon the change will be live.
But the now default layout might have an advantage for streaming, because smaller area of the window needs to be captured, since the hands and the board are together, but obv this depends on your setup too:
image
There is also a setting, that adds background to the pieces in hand:
image
I could write some dirty css stylesheet for stylus, but that's not a long term solution...

@milkymia93
Copy link

i see you updated it, thats unfortunate, i like that you can have background to the pieces in hand but its awkward because it's vertical rather than horizontal. oh well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working debatable Not sure if worth working on, or if it's something that is desirable enhancement New feature or an improvement of an existing one ideas wanted An idea how to solve issue needed
Projects
None yet
Development

No branches or pull requests

5 participants