New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kytoshogi Bot move API doesn't match with Fairy-Stockfish notation #698
Comments
I forgot to mention this in the blog post. Internally we have promotion as boolean, so introducing demotion (-) as a third possible state into the mix, didn't seem worth it, especially since the +/- notation is just redundant and doesn't make much sense overall. |
Alternatively I could just convert to the fairy notation and send that to the bots, probably easier to do... |
Is it fine if I add 'fairySfen' and 'fairyMoves' field to the json sent to bots? That will mean that the bots will need to read different json fields with kyotoshogi. I would like to keep exposing the current implementation as main for consistency, since it's showed in various places around the site. |
Yes, This would be great. Till that is done, could you send me the script you wrote in scala/ts to do this? |
Scala:
TS: lishogi/ui/ceval/src/protocol.ts Line 213 in 140d7a7
I will try to have this fixed this week. |
It's live, so it should be fine now. if something doesn't work please let me know. The fairy fields are added only to kyotoshogi responses. |
I'll try it out soon. Thanks! |
I used the API endpoint
/api/bot/game/{gameId}/move/{move}
to try an make a move for my Bot.My Bot gives the error:
As shown above Fairy-Stockfish gives the move
5e4e-
at the particular position (checked it's a legal move). But Lishogi expects something else to make this move (5e4e+
I'd assume?). Both moves are to be input in the usi format, but lishogi doesn't follow the same notation fairy-stockfish does.The text was updated successfully, but these errors were encountered: