-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnome Goggles #956
Gnome Goggles #956
Conversation
Male model with basic texture
- Fixed a typo in the asset file. - Commented out one of the entity lines in wc_headgear.txt. This seems to make the goggles visible in-game again. - Added barbershop entry for Gnome Goggles and localized them as such. - Changed the portrait_gnome_clothing_trigger to portrait_gnomish_hairstyles_trigger instead since portrait_gnome_clothing_trigger doesn't exist (as far as I know).
Added the color palette for the goggles and updated the model to prevent some clipping.
Change the pattern_mask and saturate the color palette
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I said it before but I'll say it again, these are incredible! They make the gnomes look so much more like gnomes. 😄
My only point of feedback would be to make the lenses transparent, but as you pointed out in a comment above, there seems to be a graphical issue tied to this currently. But if we can find a way around that, then they would be perfect.
If there's no way to do that, I think a good compromise might be to lower the saturation on some of the lenses. They're very faithful to how they appear in WoW, but I feel like the super-saturated colors might clash a bit with the more realistic, toned-down colors of CK3.
I also wonder if it might be better to tie the use of goggles to something else instead of just being random. For example, they could perhaps be used by gnomes with a high Learning stat so the visual would be tied to a gameplay element.
Set gnomish clothing modifiers: they don't wear crowns, their dukes and highter have goggles, sometimes courtiers have goggles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Basic gnome goggles
Changelog:
To-do list:
Tests:
wc
files inDocuments\Paradox Interactive\Crusader Kings III\logs\error.log
exceptportrait_decals.cpp:101
How to test:
Version 1.4.4