Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome Goggles #956

Merged
merged 9 commits into from
Oct 10, 2022
Merged

Gnome Goggles #956

merged 9 commits into from
Oct 10, 2022

Conversation

Chomski2
Copy link
Contributor

@Chomski2 Chomski2 commented Sep 9, 2022

Basic gnome goggles

Changelog:

  • Added goggles model for gnomes

To-do list:

  • Goggles ingame
  • Use the dynamic color palettes
  • Female model

Tests:

  • Only some characters with the gnome trait use the headgear.
  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

Version 1.4.4

Male model with basic texture
@Chomski2 Chomski2 self-assigned this Sep 9, 2022
@Chomski2 Chomski2 added priority low ❕ Shows priority 3D graphics 📐 Involves tweaking/adding 3D models cultural 🎓 Involves cultural mechanics labels Sep 9, 2022
Chomski2 and others added 3 commits September 9, 2022 19:22
- Fixed a typo in the asset file.
- Commented out one of the entity lines in wc_headgear.txt. This seems to make the goggles visible in-game again.
- Added barbershop entry for Gnome Goggles and localized them as such.
- Changed the portrait_gnome_clothing_trigger to portrait_gnomish_hairstyles_trigger instead since portrait_gnome_clothing_trigger doesn't exist (as far as I know).
Added the color palette for the goggles and updated the model to prevent some clipping.
@Chomski2 Chomski2 changed the title Male Goggles Gnome Goggles Sep 11, 2022
@Chomski2
Copy link
Contributor Author

Theres a way to make the lens of the goggles slightly transparent but then the texture of the pattern make a grid effect that I cant find a way to remove or made less visible.

Goggles without alpha
unknown

Goggles with alpha
unknown (1)

@ercarp ercarp requested review from a team and ercarp September 18, 2022 19:46
Copy link
Contributor

@ercarp ercarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I said it before but I'll say it again, these are incredible! They make the gnomes look so much more like gnomes. 😄

My only point of feedback would be to make the lenses transparent, but as you pointed out in a comment above, there seems to be a graphical issue tied to this currently. But if we can find a way around that, then they would be perfect.

If there's no way to do that, I think a good compromise might be to lower the saturation on some of the lenses. They're very faithful to how they appear in WoW, but I feel like the super-saturated colors might clash a bit with the more realistic, toned-down colors of CK3.

I also wonder if it might be better to tie the use of goggles to something else instead of just being random. For example, they could perhaps be used by gnomes with a high Learning stat so the visual would be tied to a gameplay element.

@Gaben1025 Gaben1025 added this to In Review in Release v1.0 Sep 18, 2022
Set gnomish clothing modifiers: they don't wear crowns, their dukes and highter have goggles, sometimes courtiers have goggles.
Copy link
Member

@zumbak04 zumbak04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Chomski2 Chomski2 merged commit bdb9680 into master Oct 10, 2022
@Chomski2 Chomski2 deleted the Gnome-Goggles branch October 10, 2022 17:07
@Chomski2 Chomski2 moved this from In Review to Done in Release v1.0 Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D graphics 📐 Involves tweaking/adding 3D models cultural 🎓 Involves cultural mechanics priority low ❕ Shows priority
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants