Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media macro option does not support Image Slideshow for "Any/All media source on" #965

Closed
miko3ed opened this issue Jan 1, 2024 · 5 comments · Fixed by #966
Closed

Media macro option does not support Image Slideshow for "Any/All media source on" #965

miko3ed opened this issue Jan 1, 2024 · 5 comments · Fixed by #966

Comments

@miko3ed
Copy link

miko3ed commented Jan 1, 2024

Describe the bug
When using the Media parameter to check the state of Image Slideshow sources using "Any media source" or "All media sources" in a scene are in a state the system does not seem to detect them. I have tried multiple states, but importantly the Playing & Stopped states are not functioning. If I use the "Source" option and specify an Image Slideshow it detects the state accurately, and also the Any/All options seem to work on Media Source types.

To Reproduce
Steps to reproduce the behavior:

  1. Create a scene with multiple Image Slideshow sources and populate them with any number of images
  2. Create a new Macro and select "Perform actions only on condition change"
  3. Create a Macro parameter using Media for the parameter type
  4. Specify "Any Media source on" and select your scene with Image Slideshows
  5. Set state to "Playing"
  6. Create any action that you would like to execute, I tested using System Tray Notification with a message of "Test"
  7. Enable one of the Image Slideshows in your scene

Expected behavior
When an Image Slideshow is enabled in the scene I would expect the macro to run once.

Logs
I do not know how to log this for you

Version information

  • OS: [e.g. Windows 11]
  • OBS Version [e.g. 30.0.2]
  • Plugin Version [e.g. 1.24.2]

Screenshot 2024-01-01 163356

@miko3ed
Copy link
Author

miko3ed commented Jan 1, 2024

For your information, this screenshot shows the macro working if you specify a specific Image Slideshow source in the scene
Screenshot 2024-01-01 163535

@WarmUpTill WarmUpTill linked a pull request Jan 2, 2024 that will close this issue
@WarmUpTill
Copy link
Owner

Thanks for pointing out the issue!

The problem should be fixed with the linked PR.
A build with a fix will be available here in a few minutes:
https://github.com/WarmUpTill/SceneSwitcher/actions/runs/7385618388?pr=966

@miko3ed
Copy link
Author

miko3ed commented Jan 3, 2024

Thanks much @WarmUpTill!!! Do you know when the release will be available for download?

@WarmUpTill
Copy link
Owner

WarmUpTill commented Jan 3, 2024

A build is available at the link I shared above.
You will have to be logged into GitHub to be able to download it.
I am not yet sure when I will publish a next release officially.

@miko3ed
Copy link
Author

miko3ed commented Jan 3, 2024

oh Gotcha! Thanks, sorry I just saw that step 3 wasn't done and got confuzzled. The quick fix is MUCH appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants