Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior using Transition for setting a source transition to fade #982

Closed
miko3ed opened this issue Jan 12, 2024 · 6 comments · Fixed by #984
Closed

Strange behavior using Transition for setting a source transition to fade #982

miko3ed opened this issue Jan 12, 2024 · 6 comments · Fixed by #984

Comments

@miko3ed
Copy link

miko3ed commented Jan 12, 2024

Describe the bug
When I use the Transition action to set a source's show/hide transition it creates a graphical anomaly with the fade type whereby an image or image slideshow (those are the only types I tested with) on fade out the image temporarily transforms to a smaller version of the image. If I set the show/fade transition manually it works as expected. You can see this behavior in the video file I am attaching to this ticket. I show the correct functioning of the source transitions and then execute a macro that changes them (starting at 20seconds in the video) and then I activate and deactivate the source to show the anomaly, I then reset the transitions manually and it goes back to the expected behavior.

Additional context
If I specify the source that needs to be adjusted then it works correctly. I have tried using Source Name, Sources of Type, Sources in Index Range, Source Name matches pattern, as well as Source with Index. It seems like the behavior only occurs for an instance where multiple sources are modified. If any of these modified a single source the behavior worked as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Create a scene with multiple IMAGE sources
  2. Create a macro with the Transition action set to Modify source show transition targeting your created scene and set to All Sources
  3. Add another action set to Modify source hide transition targeting your created scene and set to All Sources
  4. Execute the macro
  5. enable a source, wait 1 second, disable a source

Version information

2024-01-12.14-21-22_1.webm
@WarmUpTill
Copy link
Owner

Thanks for pointing out this issue!
It should be fixed with this build:
https://github.com/WarmUpTill/SceneSwitcher/actions/runs/7511557263?pr=984

Let me know if that resolved the issue on your side! :)

@WarmUpTill WarmUpTill linked a pull request Jan 13, 2024 that will close this issue
@miko3ed
Copy link
Author

miko3ed commented Jan 13, 2024

awesome! much appreciated. I have an unrelated question, these builds you have been doing for the tickets I open, are they just the current version plus the fix/enhancement for that particular ticket or is it a cumulative build that includes other fixes/enhancements from other tickets as well?

@WarmUpTill
Copy link
Owner

WarmUpTill commented Jan 13, 2024

They are based on the "master" branch + fixes for the particular issue at hand.
The "master" branch is not the same as the last official release and introduces additional changes.

Hope that clears things up! :)

@miko3ed
Copy link
Author

miko3ed commented Jan 15, 2024

Thanks, yeah, I understand. I'll keep an eye out for the next release :)

@WarmUpTill
Copy link
Owner

WarmUpTill commented Jan 15, 2024

Just to confirm:
Does the mentioned build resolve your problem?
In that case I will merge the changes / close this issue :)

Not sure yet when I will make the next release.

@miko3ed
Copy link
Author

miko3ed commented Jan 15, 2024

Yes, looks to be fixed, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants