Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

improve ChangeLog contents #4736

Closed
wzdev-ci opened this issue Feb 11, 2018 · 20 comments
Closed

improve ChangeLog contents #4736

wzdev-ci opened this issue Feb 11, 2018 · 20 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_patch (an actual patch, not a request for one) | by Forgon


The ChangeLog

  • contained the non-existent word "namings", which has been replaced with "names"
  • erroneously stated that version 3.2.3 set the default resolution to 1024x720 instead of 1024x768
  • used upper case inconsistently
  • used function markup inconsistently
  • was out-of-date and missing some information. I updated its contents and changed the version number of the upcoming release from 3.2.4 to 3.3.0

For the future, developers should update the ChangeLog whenever they commit important tickets.


Issue migrated from trac:4736 at 2022-04-16 13:02:26 -0700

@wzdev-ci
Copy link
Contributor Author

Forgon changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Forgon changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Forgon changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Per commented


"For the future, developers should update the ChangeLog whenever they make important commits."

This is not actually possible, since we put the commit hashes in the Changelog...

I was thinking of Trac tickets, for which this is no problem.

@wzdev-ci
Copy link
Contributor Author

Forgon changed status from closed to reopened

@wzdev-ci
Copy link
Contributor Author

Forgon changed resolution from fixed to ``

@wzdev-ci
Copy link
Contributor Author

Forgon edited the issue description

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file changelog_correction.patch (1.5 KiB)

patch file created with git format-patch (part 1/5)

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file changelog_namings.patch (0.9 KiB)

patch file created with git format-patch (part 2/5)

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file changelog_uppercase.patch (10.9 KiB)

patch file created with git format-patch (part 3/5)

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file changelog_functions.patch (6.1 KiB)

patch file created with git format-patch (part 4/5)

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file changelog_update.patch (3.9 KiB)

patch file created with git format-patch (part 5/5)

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> changed status from reopened to closed

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> changed owner from `` to Forgon2100 <forgon2100@gmail.com>

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> committed [6]


In Warzone2100/warzone2100@6cf0f57:

#CommitTicketReference repository="" revision="6cf0f572caa0bb5d21fe2c42ee702b768e3fc9e9"
fixes #4736: ChangeLog correction: version 3.2.3 set default resolution to 1024x768, not 1024x720 (patch 1/5)

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> committed [402]


In Warzone2100/warzone2100@402f493:

#CommitTicketReference repository="" revision="402f493894fb6863c6252638a46011da3e948f60"
fixes #4736: replaced non-existent word "namings" with "names" (patch 2/5)

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> committed [57]


In Warzone2100/warzone2100@57d9324:

#CommitTicketReference repository="" revision="57d9324b1ab2e085ef608bb060fba77f02823577"
fixes #4736: upper case in ChangeLog now used consistently (patch 3/5)

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> committed [4]


In Warzone2100/warzone2100@4c64406:

#CommitTicketReference repository="" revision="4c644069cad546f6fc40b5f97caef705afaf3360"
fixes #4736: markup for functions in ChangeLog now used consistently (patch 4/5)

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> committed [8]


In Warzone2100/warzone2100@8b1e581:

#CommitTicketReference repository="" revision="8b1e581e7630aa2fe31720e415c6d3aaacfd1a55"
fixes #4736: updated ChangeLog and renamed upcoming release from 3.2.4 to 3.3.0 (patch 5/5)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant