Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repackage AppHost / SingleFileHost using input file as template #420

Closed
Washi1337 opened this issue Mar 12, 2023 · 0 comments
Closed

Repackage AppHost / SingleFileHost using input file as template #420

Washi1337 opened this issue Mar 12, 2023 · 0 comments
Labels
dotnet Issues related to AsmResolver.DotNet enhancement
Milestone

Comments

@Washi1337
Copy link
Owner

Washi1337 commented Mar 12, 2023

Problem Description

Currently, the implementation of AppHost / SingleFileHost bundles requires the official apphost.exe or singlefilehost.exe template file from the .NET SDK for packaging new bundles. This is problematic, as not every host has the full SDK installed. Editing existing apphost bundles would therefore not work on these hosts, even though the input binary is effectively the template itself with just a few minor modifications.

Proposal

Allow for using the input binary as the template for apphost repackaging in BundleManifest.WriteUsingTemplate.

Alternatives

This kind of is already possible, but the current implementation assumes the template binary does not contain any bundle. Using the original code will thus result in an output file that is double the size because of a duplicated apphost bundle.

Additional Context

No response

@Washi1337 Washi1337 added enhancement dotnet Issues related to AsmResolver.DotNet labels Mar 12, 2023
@Washi1337 Washi1337 added this to the 5.2.0 milestone Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Issues related to AsmResolver.DotNet enhancement
Projects
None yet
Development

No branches or pull requests

1 participant