Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): 🐛 fixed missing error handling #114

Merged
merged 2 commits into from Jul 24, 2022
Merged

fix(java): 🐛 fixed missing error handling #114

merged 2 commits into from Jul 24, 2022

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Jul 24, 2022

Closes: #109

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@WasiqBhamla/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@github-actions github-actions bot added the 🐛 pr: bug fix PR which fixes a bug label Jul 24, 2022
@WasiqB WasiqB marked this pull request as ready for review July 24, 2022 09:31
@WasiqB WasiqB requested a review from a team as a code owner July 24, 2022 09:31
@WasiqB WasiqB merged commit 8e0757a into main Jul 24, 2022
@WasiqB WasiqB deleted the issue-109 branch July 24, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 pr: bug fix PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 New Bug: Malformed Error is thrown instaed of Custom Framework Error
1 participant