Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 cleaned up pom and updated dependencies version #147

Merged
merged 1 commit into from Aug 11, 2022
Merged

Conversation

mfaisalkhatri
Copy link
Contributor

@mfaisalkhatri mfaisalkhatri commented Aug 11, 2022

Closes: #139

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@WasiqBhamla/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@mfaisalkhatri mfaisalkhatri requested a review from a team as a code owner August 11, 2022 16:40
@mfaisalkhatri mfaisalkhatri linked an issue Aug 11, 2022 that may be closed by this pull request
4 tasks
@github-actions github-actions bot added the 💅 pr: polish PR which refactors the code label Aug 11, 2022
Copy link
Member

@WasiqB WasiqB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@WasiqB WasiqB changed the title chore: 🐛 cleaned up pom and updated dependencies version fix: 🐛 cleaned up pom and updated dependencies version Aug 11, 2022
@WasiqB WasiqB added 🐛 pr: bug fix PR which fixes a bug and removed 💅 pr: polish PR which refactors the code labels Aug 11, 2022
@WasiqB WasiqB merged commit ddde399 into develop Aug 11, 2022
@WasiqB WasiqB deleted the issue-139 branch August 11, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 pr: bug fix PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 New Bug: pom.xml Cleanup
2 participants