Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(website): 📝 started adding documentations for boyka #54

Merged
merged 7 commits into from Apr 10, 2022
Merged

docs(website): 📝 started adding documentations for boyka #54

merged 7 commits into from Apr 10, 2022

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Mar 28, 2022

Closes: #44

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Checkstyle checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarQube issues?

Reviewers

@WasiqBhamla/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@WasiqB WasiqB self-assigned this Mar 28, 2022
@WasiqB WasiqB marked this pull request as ready for review April 10, 2022 17:47
@WasiqB WasiqB requested a review from a team as a code owner April 10, 2022 17:47
@WasiqB WasiqB merged commit c3acb97 into main Apr 10, 2022
@WasiqB WasiqB deleted the issue-44 branch April 10, 2022 17:49
WasiqB added a commit that referenced this pull request Apr 17, 2022
@WasiqB
feat(java): 👔 adding missing keyboard actions (#58)
4914d7f 
* feat(java): 👔 adding missing keyboard actions

test is pending to be added

51

* docs(website): 📝 started adding documentations for boyka (#54)

* docs(website): 📝 started adding documentations for boyka

* docs(website): 💄 started adding documentation

also updated website color scheme for light and dark mode

* docs(website): 📝 working on documentation for API and Web

* docs(website): 📝 added API related docs

and removed scaffolded blog posts

* docs(website): 📝 completed adding API documentation

* docs(website): 📝 added web test documentation

* feat(java): 👔 adding missing keyboard actions

test is pending to be added

51

* feat(java): ✨ added test for pressKey method
@WasiqB WasiqB added the 📝 pr: documentation PR which adds only documentation changes label Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaisalkhatri mfaisalkhatri Awaiting requested review from mfaisalkhatri mfaisalkhatri is a code owner automatically assigned from BoykaFramework/boyka-core

Assignees

@WasiqB WasiqB

Labels
📝 pr: documentation PR which adds only documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create documentation section with complete framework documentation
1 participant
@WasiqB